← Back to issue list

nodejs plugin assumes a version key in the package.json

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1838474
Type
issue
State
open
Author
~robcresswell-deactivatedaccount
Labels
Created
2019-07-30 21:30:04.681816+00:00
Updated
2019-08-26 13:48:19.681064+00:00
Closed

Current evaluation

No evaluation has been recorded for this issue yet.

Issue body

The nodejs plugin currently assumes a version key is present in the package.json[1]; crashing out with a KeyError if it isn't, and doesn't enable any other way of providing a package version, nor does it appear to inherit or otherwise use the 'version' key in the snapcraft.yaml. What's the best way to fix this? I've really lost my patience trying to wrestle with the tooling and broken links in the documentation, so I'd like to raise a PR to address this ASAP so I can move on. 1. https://github.com/snapcore/snapcraft/blob/master/snapcraft/plugins/nodejs.py#L211

Evaluation history

No evaluation history available.